Skip to content

Derive from both variables and response for enum #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2021
Merged

Derive from both variables and response for enum #379

merged 1 commit into from
Dec 4, 2021

Conversation

juchiast
Copy link
Contributor

close #378

@juchiast
Copy link
Contributor Author

juchiast commented Nov 30, 2021 •
edited
Loading

Can someone take a look at this?

tomhoule
tomhoule approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that makes sense, @mathstuf do you see any problem coming out of this?

@tomhoule
Copy link
Member

tomhoule commented Dec 4, 2021

Merging for now, let's revert later if we discover problems.

@tomhoule tomhoule merged commit aac6444 into graphql-rust:main Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhoule tomhoule tomhoule approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enum doesn't inherit derived traits of Variables
2 participants
@juchiast @tomhoule